Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add a test for Expect & checkExpectation #15040

Closed
wants to merge 1 commit into from
Closed

test: add a test for Expect & checkExpectation #15040

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

@apapirovski apapirovski commented Aug 26, 2017 •
edited
Loading

New test case for Expect header & checkExpectation event, based on the existing http test case with structural tweaks to make it a bit easier to follow. Part of increasing http2 code coverage as per #14985

Let me know if I should change anything!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 26, 2017
@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Aug 26, 2017
@apapirovski
test: add a test for Expect & checkExpectation
922bbe2 
New test case for Expect header & checkExpectation event based on the
existing http test case.

Refs: nodejs#14985
@apapirovski apapirovski force-pushed the patch-http2-expect-header-test branch from 8ffd661 to 922bbe2 Compare August 27, 2017 12:41
jasnell
jasnell reviewed Aug 29, 2017
View reviewed changes
test/parallel/test-http2-compat-expect-handling.js
function nextTest(testsToRun) {
if (!testsToRun) {
return server.close();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can use the new Countdown utility under common... e.g.

const Countdown = require('../common/countdown');
const countdown = new Countdown(2, () => console.log('done'));
countdown.dec();
countdown.dec();

hiroppy
hiroppy approved these changes Aug 29, 2017
View reviewed changes
Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@apapirovski
Copy link
Member Author

So I just noticed that the documentation for the checkExpectation event is missing. Should I submit a separate PR with an update to the docs or include in this one? Or are we leaving it out on purpose?

@jasnell
Copy link
Member

jasnell commented Aug 29, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9869/

@jasnell
Copy link
Member

jasnell commented Aug 29, 2017

Yes, a separate PR adding the checkExpectation would be helpful

@BridgeAR
Copy link
Member

Landed in 6eeb06f

@BridgeAR BridgeAR closed this Aug 30, 2017
BridgeAR pushed a commit that referenced this pull request Aug 30, 2017
@apapirovski @BridgeAR
test: add a test for Expect & checkExpectation
6eeb06f 
New test case for Expect header & checkExpectation event based on the
existing http test case.

PR-URL: #15040
Refs: #14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Aug 31, 2017
@apapirovski @cjihrig
test: add a test for Expect & checkExpectation
952ab8c 
New test case for Expect header & checkExpectation event based on the
existing http test case.

PR-URL: nodejs#15040
Refs: nodejs#14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@apapirovski apapirovski deleted the patch-http2-expect-header-test branch September 4, 2017 14:36
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 5, 2017
@apapirovski @addaleax
test: add a test for Expect & checkExpectation
d97d5cb 
New test case for Expect header & checkExpectation event based on the
existing http test case.

PR-URL: nodejs/node#15040
Refs: nodejs/node#14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@apapirovski @MylesBorins
test: add a test for Expect & checkExpectation
b3267a3 
New test case for Expect header & checkExpectation event based on the
existing http test case.

PR-URL: #15040
Refs: #14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@apapirovski @MylesBorins
test: add a test for Expect & checkExpectation
d176a18 
New test case for Expect header & checkExpectation event based on the
existing http test case.

PR-URL: #15040
Refs: #14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@apapirovski @jasnell @BridgeAR @cjihrig @hiroppy @mscdex @MylesBorins @nodejs-github-bot